Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't look for a jupyter interpreter when creating blank notebook #8596

Merged
merged 3 commits into from
Nov 14, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Nov 14, 2019

For #8481

Also fixed #8594 as that was broken by a previous checkin for this milestone.

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #8596 into master will increase coverage by 0.44%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8596      +/-   ##
=========================================
+ Coverage   59.05%   59.5%   +0.44%     
=========================================
  Files         512     512              
  Lines       23762   23766       +4     
  Branches     3838    3845       +7     
=========================================
+ Hits        14033   14141     +108     
+ Misses       8799    8706      -93     
+ Partials      930     919      -11
Impacted Files Coverage Δ
...ient/datascience/interactive-ipynb/nativeEditor.ts 61.6% <78.57%> (+4.55%) ⬆️
src/client/datascience/constants.ts 100% <0%> (+0.33%) ⬆️
src/client/common/installer/productInstaller.ts 77.24% <0%> (+0.52%) ⬆️
src/client/common/process/proc.ts 14.84% <0%> (+1.56%) ⬆️
src/client/interpreter/locators/helpers.ts 73.17% <0%> (+2.43%) ⬆️
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/linters/pylint.ts 98.18% <0%> (+3.63%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/datascience/debugLocationTracker.ts 83.01% <0%> (+3.77%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4cb1d...125e36c. Read the comment docs.

@rchiodo rchiodo merged commit d598d72 into master Nov 14, 2019
@rchiodo rchiodo deleted the rchiodo/8481_blank_server_access branch November 14, 2019 23:45
rchiodo added a commit that referenced this pull request Nov 15, 2019
)

* Creating a new blank notebook should not require a search for jupyter.

* Fix bug caused by other fix.
@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing 'z' in a cell causes the cell to disappear
3 participants