Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout to be what it was before. 10 seconds isn't long enough #8504

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Nov 11, 2019

Jim hit this on Friday
I just hit this today trying to test the release branch
We have yet to ship the new timeout, so putting back before we ship.

@rchiodo rchiodo added the no-changelog No news entry required label Nov 11, 2019
@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #8504 into release-2019.11 will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2019.11    #8504      +/-   ##
===================================================
+ Coverage            59.14%   59.46%   +0.32%     
===================================================
  Files                  509      509              
  Lines                23390    23390              
  Branches              3774     3779       +5     
===================================================
+ Hits                 13834    13909      +75     
+ Misses                8650     8575      -75     
  Partials               906      906
Impacted Files Coverage Δ
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 70.51% <0%> (+12.82%) ⬆️
src/client/api.ts 92.85% <0%> (+14.28%) ⬆️
src/client/common/utils/icons.ts 100% <0%> (+16.66%) ⬆️
...cience/jupyter/jupyterDebuggerNotInstalledError.ts 80% <0%> (+20%) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (+25%) ⬆️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 100% <0%> (+25%) ⬆️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (+33.33%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b79a503...412610d. Read the comment docs.

@rchiodo rchiodo merged commit 5a689a3 into release-2019.11 Nov 11, 2019
@rchiodo rchiodo deleted the rchiodo/release_fixtimeout branch November 11, 2019 17:29
@lock lock bot locked as resolved and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants