Port blue icon and altair background fixes into release #8470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
approved these changes
Nov 8, 2019
DavidKutu
reviewed
Nov 8, 2019
| extraButton, | ||
| doubleClick: noop | ||
| // Text based mimeTypes don't get a white background | ||
| if (/^text\//.test(mimeType)) { |
There was a problem hiding this comment.
This is my porting of the previous changes into the release branch. They came in after the release snap, but we want them in this release.
DavidKutu
approved these changes
Nov 8, 2019
Codecov Report
@@ Coverage Diff @@
## release-2019.11 #8470 +/- ##
================================================
Coverage 59.46% 59.46%
================================================
Files 509 509
Lines 23390 23390
Branches 3779 3779
================================================
Hits 13909 13909
Misses 8575 8575
Partials 906 906Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #
#8452
#8449
Porting the above PRs into release
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)