Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate conda environment using path when name is not available #8397

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

karthiknadig
Copy link
Member

For #3834

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Unit tests & system/integration tests are added/updated

@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #8397 into master will increase coverage by 0.09%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8397      +/-   ##
==========================================
+ Coverage   59.37%   59.46%   +0.09%     
==========================================
  Files         509      509              
  Lines       23299    23389      +90     
  Branches     3763     3779      +16     
==========================================
+ Hits        13833    13908      +75     
- Misses       8567     8575       +8     
- Partials      899      906       +7
Impacted Files Coverage Δ
src/client/interpreter/locators/services/conda.ts 100% <100%> (ø) ⬆️
...lient/interpreter/locators/services/condaHelper.ts 90.62% <66.66%> (-0.56%) ⬇️
...mentActivationProviders/condaActivationProvider.ts 94.23% <84.61%> (+0.11%) ⬆️
src/client/datascience/jupyter/jupyterExecution.ts 50.69% <0%> (-0.35%) ⬇️
...science/jupyter/liveshare/guestJupyterExecution.ts 22.91% <0%> (ø) ⬆️
src/client/datascience/cellFactory.ts 70.51% <0%> (ø) ⬆️
src/client/datascience/common.ts 92.78% <0%> (ø) ⬆️
src/client/datascience/serviceRegistry.ts 0% <0%> (ø) ⬆️
...ascience/jupyter/liveshare/hostJupyterExecution.ts 45.45% <0%> (ø) ⬆️
src/client/datascience/jupyter/jupyterServer.ts 9.45% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db47aa...fba2548. Read the comment docs.

@karthiknadig karthiknadig marked this pull request as ready for review November 7, 2019 19:30
@karthiknadig karthiknadig merged commit f9c1f97 into microsoft:master Nov 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 15, 2019
@karthiknadig karthiknadig deleted the issue3834 branch December 27, 2019 02:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants