🐛 Fixes #700 replace back slashes in fie paths with forward slashes #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archive of 0.7.0
* 'master' of https://github.com/Microsoft/vscode-python: Fixes #56 list all environments (#219) Fixes #57 Disable activation on debugging (#220) Fixes #26 Do not run linters when linters are disabled (#222)
* upstream/master: Fix typo in README.md (#252) Disable linter without workspaces (#241)
* upstream/master: Fix feedback service (#246) Fix django context initializer (#248) disable generation of tags file upon extension load (#264)
* upstream/master: Resolve pythonPath before comparing it to shebang (#273)
* upstream/master:
Fixes #22 to Detect anaconda from known locations (#221)
Use workspaceFolder token instead of workspaceRoot (#267)
Fix registry lookup response (#224)
Fix issues when running without debugging and debugged code terminates (#249)
* upstream/master: Fix debugging tests (#304)
* upstream/master: Remove jupyter functionality in favor of Jupyter extension (#302) Drop Python 2 URLs (#307)
* upstream/master: Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)
* upstream/master: Remove setting linting.lintOnTextChange as it was never implemented (#315)
* upstream/master: Fix travis build error (#326)
* upstream/master: add new npm deps with improved gulp for dev (#328)
* upstream/master: Update version of inversify package (#329)
* upstream/master: Document our dev process (#330)
* upstream/master: Document contribution to the code along with coding standards (#321)
* upstream/master: Add Simplified Chinese translation of commands (#240)
* upstream/master: Fix package.json (#347)
* upstream/master: #34, #110 - suppress Intellisense in strings and comments (#339) Re-factor code python execution framework (#345)
* upstream/master: Fix linters to make use of the new python code execution framework (#360) Update the versioning scheme (#356) Make npm happy in regards to line endings (#357)
* upstream/master: Ensure python path is not set if already set in user settings (#369) Use 'an' rather than 'a' before vowel words (#373)
* upstream/master: Use new environment variable parser (#362)
* upstream/master: Make use of new execution layer instead of spawning processes (#425) Use localhost instead of 0.0.0.0 for all local socket servers (#417) Provide full signature help with highlighted parameter (#416) Change `os.arch()` to `npm` `arch` to fix wrong arch detection. (#419) Document our Russian support (#424) Bump the version number to the next release as an alpha (#422) Russian translation (#411) Speed up virtual environment detection in workspace (#405)
* upstream/master: Refactor formatters to use new execution framework (#426)
* upstream/master: Release 0.9.1 (#458) Add localization for Japanese (#434) Add Svn to uriSchemesToIgnore (#443)
* upstream/master: Refactor parsing of environment variables (after 439) (#466) Refactor extension to remove old way of spawning python processes (#439)
* upstream/master: Common execution for python tool or module (#468)
* upstream/master: Complete refactoring of code to use new code exec engine (#493)
* upstream/master: Improve interpreter selection on different platforms (#517) Yarn and code coverage (#475)
* upstream/master: Remove Homebrew installation (#537) Introduce per user installation of modules and elevated global install as an option (#532) Fix spawn args (#489)
* upstream/master: Add `pudb` set trace statement to snippets (#370)
* upstream/master: Fix auto-indent regex rules (#562) Fix linter installation (#557) Upload buillds to azure (#534) Delete package-lock.json file (#550) Fix exception reported in #447 (#536)
* upstream/master: Move badges to the official location within package.json (#587) Update contributing guide to mention our monthly release cycle (#567) Move issue template to the .github directory (#566)
* upstream/master: Added unit test attaching a debugger (#597) Add delay for exec in terminal (#592) Update TPN for opn and arch (#600) Clean build output (#595) import specific parts of rxjs to speed up loading (#596)
* upstream/master: update reflect metadata dependency (#604)
* upstream/master: WIP - Activate environment in terminal (#614) Add telemetry for debugger (#546)
* upstream/master: Implements linting configuration (#599)
* upstream/master: Add command to create a python terminal (#625) Always display interpreter status bar (#623) Do not clear interpreter cache (#621)
* upstream/master: Create a release candidate (#663) Activation of terminal using conda activate and fixes to powershell script execution (#665)
| @@ -47,5 +52,16 @@ String.prototype.toCommandArgument = function (this: string): string { | |||
| if (!this) { | |||
| return this; | |||
| } | |||
| return (this.indexOf(' ') > 0 && !this.startsWith('"') && !this.endsWith('"')) ? `"${this}"` : this.toString(); | |||
| return (this.indexOf(' ') >= 0 && !this.startsWith('"') && !this.endsWith('"')) ? `"${this}"` : this.toString(); | |||
There was a problem hiding this comment.
Does it need to be this.toCommandArgument(this.ToString()) or we don't care about spaces after the toString() conversion?
There was a problem hiding this comment.
Don't care about spaces. The change was added to ensure unit test passed, in case we have an empty string with spaces " " (I don't see how that would ever be a valid argument, but I'm supporting that just in case there are some tools that do require it).
| @@ -47,5 +52,16 @@ String.prototype.toCommandArgument = function (this: string): string { | |||
| if (!this) { | |||
| return this; | |||
| } | |||
| return (this.indexOf(' ') > 0 && !this.startsWith('"') && !this.endsWith('"')) ? `"${this}"` : this.toString(); | |||
| return (this.indexOf(' ') >= 0 && !this.startsWith('"') && !this.endsWith('"')) ? `"${this}"` : this.toString(); | |||
There was a problem hiding this comment.
We don't use single quotes in the code. its only double quotes used. So this should be ok. The check is there to ensure this doesn't fail if we call this twice.
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
=========================================
+ Coverage 62.39% 62.4% +<.01%
=========================================
Files 241 241
Lines 11109 11113 +4
Branches 2001 2002 +1
=========================================
+ Hits 6932 6935 +3
- Misses 4169 4170 +1
Partials 8 8
Continue to review full report at Codecov.
|
MikhailArkhipov
approved these changes
Feb 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700