-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "pathMappings" in "launch" debug configs. #7024
Support "pathMappings" in "launch" debug configs. #7024
Conversation
src/test/debugger/extension/configuration/resolvers/attach.unit.test.ts
Outdated
Show resolved
Hide resolved
src/test/debugger/extension/configuration/resolvers/launch.unit.test.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #7024 +/- ##
==========================================
+ Coverage 58.29% 58.38% +0.08%
==========================================
Files 483 483
Lines 21347 21421 +74
Branches 3445 3474 +29
==========================================
+ Hits 12445 12507 +62
- Misses 8124 8141 +17
+ Partials 778 773 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to understand the test code before merging it. Things seem a bit magical.
src/test/debugger/extension/configuration/resolvers/launch.unit.test.ts
Outdated
Show resolved
Hide resolved
As far as I can tell, the current CI failures here are unrelated to this PR. |
@ericsnowcurrently You will have to rebase from |
(for #3568)
[ ] Test plan is updated as appropriate[ ]package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.