Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opting out of telemetry correctly opts out of A/B testing #6272

Merged
merged 3 commits into from
Jun 21, 2019
Merged

Opting out of telemetry correctly opts out of A/B testing #6272

merged 3 commits into from
Jun 21, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Jun 20, 2019 •
edited
Loading

For #6270 #5042

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@karrtikr karrtikr requested a review from kimadeline June 20, 2019 23:18
@karrtikr karrtikr merged commit 6cdd66f into microsoft:master Jun 21, 2019
@karrtikr karrtikr deleted the optoutofab branch June 21, 2019 00:15
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kimadeline kimadeline kimadeline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karrtikr @kimadeline