Fix some problems in the pytest adapter. #5648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
force-pushed
the
pytest-adapter-cleanup
branch
from
c90c1c4 to
4bfc859
Compare
10 tasks
ericsnowcurrently
force-pushed
the
pytest-adapter-cleanup
branch
from
4bfc859 to
0762284
Compare
DonJayamanne
requested changes
Jun 10, 2019
There was a problem hiding this comment.
Over all good, with few changes:
- Please remove
TODOor add issues for them. - When raising exceptions, please add messages so one doens't need to figure out why the exceptions were thrown.
- Please document the JSON that's returned by this test adapter. This was requested in another PR but still not done. As a user of this code, I don't want to read multiple parts of the code to figure out what's being returned and the structure of the over all JSON (& possible values).
|
Any reason for not addressing the following:
|
DonJayamanne
requested changes
Jun 12, 2019
| traceback.print_stack() | ||
|
|
||
| msg = 'Unexpected pytest node (see printed output).' | ||
| exc = NotImplementedError(msg) |
There was a problem hiding this comment.
Do we really need to create a variable for this? Feels rather unnecessary.
Why not just inline this string?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(for #5458)
This is part of the effort to ensure that the pytest adapter can cope with unexpected circumstances (e.g. tests produced by third-party pytest plugins).
Note that this supercedes #5491.
[ ] Has a news entry file (remember to thank yourself!)[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.