Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev flag to poetry installer #5495

Merged
merged 3 commits into from
May 9, 2019
Merged

Conversation

Yanpas
Copy link

@Yanpas Yanpas commented Apr 26, 2019

For #5496

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

By default new dependencies like yapf, autopep8 are installed to all dependencies, --dev installs them to tool.poetry.dev-dependencies

@msftclas
Copy link

msftclas commented Apr 26, 2019

CLA assistant check
All CLA requirements met.

@ethanhs
Copy link

ethanhs commented May 9, 2019

Just ran into this today. Would love to see it merged so it will make into 2019.5. Thank you for an awesome extension!

@karrtikr karrtikr merged commit 4614cca into microsoft:master May 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants