Remove Homebrew installation #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 1, 2017 10:18
added 23 commits
December 23, 2017 09:44
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
- Coverage 56.4% 56.25% -0.16%
==========================================
Files 212 212
Lines 10018 9975 -43
Branches 1762 1753 -9
==========================================
- Hits 5651 5611 -40
+ Misses 4362 4359 -3
Partials 5 5
Continue to review full report at Codecov.
|
brettcannon
reviewed
Jan 5, 2018
| if (interpreters.length > 0) { | ||
| if (this.platform.isMac && | ||
| const platform = this.serviceContainer.get<IPlatformService>(IPlatformService); | ||
| if (platform.isMac && | ||
| settings.pythonPath === 'python' && | ||
| interpreters[0].type === InterpreterType.Unknown) { | ||
| await this.shell.showWarningMessage('Selected interpreter is MacOS system Python which is not recommended. Please select different interpreter'); |
There was a problem hiding this comment.
"macOS" and do we want to say anything about virtual environments being okay?
There was a problem hiding this comment.
It won't show up for VE (Unknown means regular env AFACT). We can add something more, but VSC messages are one-liners so it may not be fully visible. I'll fix the trademark
brettcannon
approved these changes
Jan 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just open Python download page as on Windows