Rework restart/interrupt to actually restart the entire server #5182
Conversation
| const no = localize.DataScience.restartKernelMessageNo(); | ||
| this.applicationShell.showInformationMessage(message, yes, no).then(v => { | ||
| if (v === yes) { | ||
| this.restartKernelInternal().ignoreErrors(); |
There was a problem hiding this comment.
From my reading I think this is intentional, but it looks like interruptKernel and restartKernel are not handling their asyncness the same way with regards to this. In particular restart uses await for the operations so it doesn't return back until the operations are done, but interruptKernel can return back while the restart operation is still queued. Is that how it's intended?
There was a problem hiding this comment.
Actually never mind it's already in a then. Never mind.
In reply to: 274037540 [](ancestors = 274037540)
There was a problem hiding this comment.
I think I should just await the showInformationMessage and then await the restartKernelInternal. That would be clearer. It wasn't directly intended for it to queue up the restart.
In reply to: 274037540 [](ancestors = 274037540)
| this.restartKernelInternal().ignoreErrors(); | ||
| } | ||
| }); | ||
| } else if (result === InterruptResult.Restarted) { |
There was a problem hiding this comment.
[](start = 18, length = 1)
extra space here.
For #5025
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)