Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track telemetry when switching to and from LS #5164

Merged
merged 3 commits into from
Apr 8, 2019

Conversation

DonJayamanne
Copy link

For #5162

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [n/a] Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #5164 into release will decrease coverage by 15%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           release   #5164     +/-   ##
=========================================
- Coverage       77%     62%    -14%     
=========================================
  Files          450     373     -77     
  Lines        21721   14700   -7021     
  Branches      3570    1164   -2406     
=========================================
- Hits         16635    9108   -7527     
- Misses        5081    5390    +309     
- Partials         5     202    +197
Flag Coverage Δ
#Linux ?
#Windows ?
#macOS ?

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Apr 8, 2019
src/client/activation/activationService.ts Outdated Show resolved Hide resolved
@DonJayamanne DonJayamanne merged commit 2a0c89f into release Apr 8, 2019
DonJayamanne added a commit that referenced this pull request Apr 8, 2019
DonJayamanne added a commit that referenced this pull request Apr 8, 2019
* release: (24 commits)
  Bump extension version
  Bump language server
  Track telemetry when switching to and from LS (#5164)
  Point release with fixes for Debugger (#5160)
  March 2019 point release with debugger fixes (#5056)
  Update change log
  Capture telemetry when tests are disabled (#4997)
  Point release for March 2018 (#4965)
  Same logic for stable and beta (#4964)
  Release for march 2018 (#4931)
  Bump pinned version of Language Server
  Fix change log
  Ensure output panel does not steal focus due to ls errors (#4919)
  Bump ptvsd to 4.2.5 (#4904)
  Update change log entries
  Revert "Revert "Always use the same jedi environment (#4687)" (#4850)"
  cherry pick from master branch
  Cherry-pick 26a7b9c
  Fix multiline comments with text on first line. (#4884)
  fix names for run above and run below code lenses (#4879)
  ...
DonJayamanne added a commit that referenced this pull request Apr 8, 2019
* New release
* Bumnp ptvsd and ls
* Updated ptvsd
* Track telemetry when switching to and from LS (#5164)
* Capture telemetry when switching LS
* Update changelog
* Update src/client/activation/activationService.ts
Co-Authored-By: DonJayamanne <[email protected]>
* Bump language server
* Bump extension version
@DonJayamanne DonJayamanne deleted the trackSwitchFromLS branch April 8, 2019 23:15
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants