Add prompt to select virtual environment for the worskpace #5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
force-pushed
the
is4908
branch
2 times, most recently
from
8e72118
to
1d04906
Compare
DonJayamanne
requested changes
Apr 3, 2019
DonJayamanne
requested changes
Apr 3, 2019
karrtikr
force-pushed
the
is4908
branch
3 times, most recently
from
5c66764
to
09a6edb
Compare
karrtikr
changed the title
DonJayamanne
requested changes
Apr 5, 2019
src/client/interpreter/locators/services/workspaceVirtualEnvWatcherService.ts
Outdated
Show resolved
Hide resolved
src/client/interpreter/locators/services/workspaceVirtualEnvWatcherService.ts
Outdated
Show resolved
Hide resolved
src/client/interpreter/locators/services/workspaceVirtualEnvWatcherService.ts
Outdated
Show resolved
Hide resolved
src/test/interpreters/locators/cacheableLocatorService.unit.test.ts
Outdated
Show resolved
Hide resolved
DonJayamanne
previously requested changes
Apr 5, 2019
karrtikr
force-pushed
the
is4908
branch
7 times, most recently
from
a4ed22b
to
b2de48e
Compare
DonJayamanne
previously requested changes
Apr 8, 2019
There was a problem hiding this comment.
Please add tests for the following scenarios:
- If a global interpreter is selected and the extension detects the existence of a new virtual environment
Note: Above is the scenario we're trying to address, hence a test MUST exist for this. I.e are we addressing the requirement?
Co-Authored-By: karrtikr <[email protected]>
The PMs updated me that we are indifferent if global interpreter is selected or not, we'll show the prompt in both cases. Updated accordingly. |
DonJayamanne
requested changes
Apr 10, 2019
DonJayamanne
approved these changes
Apr 10, 2019
Co-Authored-By: karrtikr <[email protected]>
DonJayamanne
approved these changes
Apr 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4908
[ ] Test plan is updated as appropriate[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)[ ] The wiki is updated with any design decisions/details.