Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an icon for "unknown" test status. #4635

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Mar 4, 2019

(for #4578)

Note: the icons are basic place-holders.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #4635 into master will increase coverage by 1%.
The diff coverage is 67%.

@@          Coverage Diff           @@
##           master   #4635   +/-   ##
======================================
+ Coverage      77%     77%   +1%     
======================================
  Files         445     445           
  Lines       21076   21077    +1     
  Branches     3423    3423           
======================================
+ Hits        16216   16217    +1     
  Misses       4854    4854           
  Partials        6       6
Flag Coverage Δ
#Linux 65% <67%> (+1%) ⬆️
#Windows 66% <67%> (ø) ⬇️
#macOS 65% <67%> (+1%) ⬆️

@ericsnowcurrently ericsnowcurrently merged commit 7500750 into microsoft:master Mar 5, 2019
@ericsnowcurrently ericsnowcurrently deleted the fix-4578-unknown-test-status-icon branch March 5, 2019 16:22
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants