conditionally import reflect-metadata and fix run without debug #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brettcannon changes ready, with bumped version number. |
DonJayamanne
requested review from
MikhailArkhipov
and removed request for
brettcannon
| @@ -1,4 +1,9 @@ | |||
| 'use strict'; | |||
| // This line should always be right on top. | |||
| if (Reflect.metadata === undefined) { | |||
There was a problem hiding this comment.
Does it matter which extension is loaded first? Looks we are are loading if it is not loaded, but is AI OK with using module we load if Python extension was activated first?
MikhailArkhipov
approved these changes
Dec 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reflect-metadata(fixes Activating extensionms-python.pythonfailed: Missing required @injectable annotation in: PersistentStateFactory. #432)pathmodule (fixes Script containing sys.exit(255) throws an Error on visualstudio_py_launcher_nodebug.py #454)