Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added action buttons to top of Test Explorer #4327

Merged
merged 7 commits into from
Feb 8, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Feb 8, 2019

For #4275

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #4327 into master will increase coverage by 22%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #4327     +/-   ##
========================================
+ Coverage      56%     78%    +22%     
========================================
  Files         361     436     +75     
  Lines       15272   20244   +4972     
  Branches     2373    3246    +873     
========================================
+ Hits         8494   15612   +7118     
+ Misses       6234    4629   -1605     
+ Partials      544       3    -541
Flag Coverage Δ
#Linux 67% <ø> (?)
#Windows 67% <ø> (?)
#macOS 66% <ø> (?)

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karrtikr
Copy link
Author

karrtikr commented Feb 8, 2019

  • Problems (failed)

@DonJayamanne Can you elaborate? The issue doesn't state this. Should i have a button for that?

@DonJayamanne
Copy link

  • Problems (failed)

Please ignore that comment.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the same names and images from vscode:

  • use start.svg instead of play.svg
  • use debug.svg instead of debugger.svg
  • use start-failed.svg instead of playFailed.svg

Please ensure you test the icons in both light and dark themes of VS code.

package.json Outdated Show resolved Hide resolved
src/client/activation/activationManager.ts Outdated Show resolved Hide resolved
@karrtikr karrtikr merged commit 6311efe into microsoft:master Feb 8, 2019
@karrtikr karrtikr deleted the testexplorer branch February 8, 2019 22:08
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants