Ensure interpreter is auto selected before updating status bar #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
force-pushed
the
fixesForAutoSelectionAndValidation
branch
from
026cfda
to
f0d70c8
Compare
karrtikr
reviewed
Jan 24, 2019
karrtikr
reviewed
Jan 24, 2019
karrtikr
reviewed
Jan 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #4139 +/- ##
=======================================
+ Coverage 79% 79% +1%
=======================================
Files 408 409 +1
Lines 18779 18921 +142
Branches 3035 3063 +28
=======================================
+ Hits 14735 14865 +130
- Misses 4041 4053 +12
Partials 3 3
|
DonJayamanne
added a commit
that referenced
this pull request
Jan 25, 2019
karrtikr
reviewed
Jan 25, 2019
| @@ -11,7 +11,7 @@ import { EXTENSION_ROOT_DIR } from '../../client/constants'; | |||
| import { sendTelemetryEvent } from '../../client/telemetry'; | |||
| import { correctPathForOsType } from '../common'; | |||
|
|
|||
| suite('Telemetry', () => { | |||
| suite('xTelemetry', () => { | |||
karrtikr
reviewed
Jan 25, 2019
| import { IServiceContainer } from '../../client/ioc/types'; | ||
|
|
||
| enum OS { | ||
| Mac, Windows, Linux | ||
| } | ||
|
|
||
| suite('Interpreters - PipEnv', () => { | ||
| suite('xInterpreters - PipEnv', () => { |
karrtikr
reviewed
Jan 25, 2019
| @@ -30,7 +30,7 @@ import { InterpreterHelper } from '../../../client/interpreter/helpers'; | |||
|
|
|||
| const preferredGlobalInterpreter = 'preferredGlobalPyInterpreter'; | |||
|
|
|||
| suite('Interpreters - Auto Selection', () => { | |||
| suite('xInterpreters - Auto Selection', () => { | |||
karrtikr
reviewed
Jan 28, 2019
| @@ -21,6 +21,10 @@ export class ApplicationDiagnostics implements IApplicationDiagnostics { | |||
| this.serviceContainer.get<ISourceMapSupportService>(ISourceMapSupportService).register(); | |||
| } | |||
| public async performPreStartupHealthCheck(resource: Resource): Promise<void> { | |||
| // When testing, do not perform health checks, as modal dialogs can be displayed. | |||
| if (!isTestExecution()) { | |||
There was a problem hiding this comment.
Incorrect. Replace if (!isTestExecution()) with if (isTestExecution()).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3501
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)