Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in pythonPath setting name #3991

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Conversation

dlech
Copy link

@dlech dlech commented Jan 15, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #3991 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #3991    +/-   ##
=======================================
- Coverage      79%     78%   -<1%     
=======================================
  Files         407     412     +5     
  Lines       18583   19083   +500     
  Branches     2992    3074    +82     
=======================================
+ Hits        14564   14877   +313     
- Misses       4016    4203   +187     
  Partials        3       3
Flag Coverage Δ
#Linux 67% <ø> (ø) ⬇️
#Windows 68% <ø> (ø) ⬇️
#macOS 67% <ø> (ø) ⬇️
Impacted Files Coverage Δ
src/client/application/diagnostics/base.ts 86% <0%> (-7%) ⬇️
...lication/diagnostics/checks/invalidDebuggerType.ts 33% <0%> (-2%) ⬇️
src/client/application/diagnostics/types.ts 100% <0%> (ø) ⬆️
src/client/activation/languageServer/downloader.ts 50% <0%> (ø)
...c/client/activation/languageServer/platformData.ts 79% <0%> (ø)
.../activation/languageServer/downloadChannelRules.ts 85% <0%> (ø)
src/client/activation/languageServer/progress.ts 45% <0%> (ø)
...ctivation/languageServer/interpreterDataService.ts 32% <0%> (ø)
...t/application/diagnostics/checks/lsNotSupported.ts 79% <0%> (+1%) ⬆️
src/client/common/utils/localize.ts 98% <0%> (+1%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9f738...f40d415. Read the comment docs.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix, please could you:

@dlech
Copy link
Author

dlech commented Jan 18, 2019

done (although I must admit fixing a typo hardly seems newsworthy 😆)

@DonJayamanne
Copy link

although I must admit fixing a typo hardly seems newsworthy

We'd like to ensure the efforts of external contributors are recognized and appreciated.

@DonJayamanne DonJayamanne merged commit d535738 into microsoft:master Jan 18, 2019
@dlech dlech deleted the patch-1 branch January 18, 2019 23:36
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants