Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem Ian found with the collapse/expand in the codemirror #3983

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Fix problem Ian found with the collapse/expand in the codemirror #3983

merged 2 commits into from
Jan 15, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Jan 14, 2019

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@rchiodo rchiodo self-assigned this Jan 14, 2019
IanMatthewHuff
IanMatthewHuff approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit 5f0153c into master Jan 15, 2019
@rchiodo rchiodo deleted the rchiodo/fix_codemirror branch January 23, 2019 19:24
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

Assignees

@rchiodo rchiodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchiodo @IanMatthewHuff