Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-978: Escape the pipenv executable for activation. #3975

Conversation

ericsnowcurrently
Copy link
Member

(for #978)

I missed a corner case in #3957. This fixes it.

@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #3975 into master will increase coverage by 1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3975   +/-   ##
======================================
+ Coverage      78%     78%   +1%     
======================================
  Files         406     406           
  Lines       18892   18892           
  Branches     3028    3028           
======================================
+ Hits        14642   14644    +2     
+ Misses       4248    4246    -2     
  Partials        2       2
Flag Coverage Δ
#Linux 68% <0%> (+1%) ⬆️
#Windows 68% <0%> (+1%) ⬆️
#macOS 68% <0%> (ø) ⬇️
Impacted Files Coverage Δ
...entActivationProviders/pipEnvActivationProvider.ts 79% <100%> (ø) ⬆️
src/client/interpreter/helpers.ts 79% <0%> (-1%) ⬇️
src/client/common/platform/fileSystem.ts 64% <0%> (ø) ⬇️
src/client/providers/jediProxy.ts 77% <0%> (ø) ⬇️
src/client/common/process/pythonProcess.ts 93% <0%> (+2%) ⬆️
...rpreter/locators/services/baseVirtualEnvService.ts 88% <0%> (+3%) ⬆️
...tors/services/workspaceVirtualEnvWatcherService.ts 90% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c013089...efe8172. Read the comment docs.

@ericsnowcurrently
Copy link
Member Author

close-reopen to re-trigger CI

@ericsnowcurrently ericsnowcurrently merged commit 7706633 into microsoft:master Jan 14, 2019
@ericsnowcurrently ericsnowcurrently deleted the fix-978-add-pipenvPath-setting branch January 14, 2019 20:22
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants