Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default debug config and fix labels #3860

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Add default debug config and fix labels #3860

merged 2 commits into from
Jan 4, 2019

Conversation

DonJayamanne
Copy link

For #3321

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [no] Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • [no] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jan 3, 2019
ericsnowcurrently
ericsnowcurrently approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Just to make sure I understood, you were able to remove PythonDebugConfigurationProvider because it's not used anywhere?

src/client/debugger/extension/configuration/debugConfigurationService.ts Show resolved Hide resolved
@DonJayamanne DonJayamanne merged commit 064b837 into microsoft:master Jan 4, 2019
@DonJayamanne DonJayamanne deleted the fixMessagesInDebugger branch May 24, 2019 20:24
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @ericsnowcurrently