-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default behavior for debugging of Flask #2954
Change default behavior for debugging of Flask #2954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* @implements {Disposable} | ||
*/ | ||
@injectable() | ||
export class ProcecssTerminationEventHandler implements IDebugSessionEventHandlers, Disposable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Proce
cssTerminationEventHandler
src/client/debugger/types.ts
Outdated
gevent?: boolean; | ||
jinja?: boolean; | ||
debugStdLib?: boolean; | ||
export interface IKnwonAttachDebugArguments extends ICommonDebugArguments { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IKn
ownAttachDebugArguments
@DonJayamanne The issue says it is merged, but when using Visual Studio Code 1.35.1 (the currently newest version) on Windows with the version 2019.6.22090 of the Python extension the launch.json still has the old command line arguments (--no-reload, etc.) set to true and removing them causes Visual Studio Code to no longer hit breakpoints in changed files. So is this still not in the live version and is there any ETA for when to expect this to work as expected? |
For #80
For #2326
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)