Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default behavior for debugging of Flask #2954

Merged
merged 11 commits into from
Oct 23, 2018

Conversation

DonJayamanne
Copy link

For #80
For #2326

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* @implements {Disposable}
*/
@injectable()
export class ProcecssTerminationEventHandler implements IDebugSessionEventHandlers, Disposable {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ProcecssTerminationEventHandler

gevent?: boolean;
jinja?: boolean;
debugStdLib?: boolean;
export interface IKnwonAttachDebugArguments extends ICommonDebugArguments {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IKnownAttachDebugArguments

@DonJayamanne DonJayamanne merged commit 68f8423 into microsoft:master Oct 23, 2018
@DonJayamanne DonJayamanne deleted the terminateChildProcs branch October 31, 2018 17:37
@danstur
Copy link

danstur commented Jul 2, 2019

@DonJayamanne The issue says it is merged, but when using Visual Studio Code 1.35.1 (the currently newest version) on Windows with the version 2019.6.22090 of the Python extension the launch.json still has the old command line arguments (--no-reload, etc.) set to true and removing them causes Visual Studio Code to no longer hit breakpoints in changed files.

So is this still not in the live version and is there any ETA for when to expect this to work as expected?

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants