Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1944: Support a new "python.condaPath" setting, in case conda not on PATH. #2605

Conversation

ericsnowcurrently
Copy link
Member

(fixes #1944)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has unit tests & system/integration tests
  • Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@ericsnowcurrently
Copy link
Member Author

FYI, the only failing test is the known "Multiple linters" issue, so I'll merge this once I have a passing review.

@brettcannon brettcannon merged commit 5232537 into microsoft:master Sep 17, 2018
@ericsnowcurrently ericsnowcurrently deleted the fix-1944-activate-conda-not-on-path branch September 17, 2018 21:42
ericsnowcurrently added a commit that referenced this pull request Sep 24, 2018
Fixes #1944. This is a follow-up to #2605.

Make sure PythonSettings.condaPath is populated from the VSC settings.
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda environments detected as Python installs (not conda) when conda not on PATH.
4 participants