Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable python shell integration for wsl #24446

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

anthonykim1
Copy link

Resolves: #23829

From testing:
Screenshot 2024-11-14 at 11 54 44 PM

@anthonykim1 anthonykim1 added this to the November 2024 milestone Nov 15, 2024
@anthonykim1 anthonykim1 self-assigned this Nov 15, 2024
@anthonykim1 anthonykim1 added the bug Issue identified by VS Code Team member as probable bug label Nov 15, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review November 15, 2024 08:12
@anthonykim1 anthonykim1 enabled auto-merge (squash) November 15, 2024 08:20
@anthonykim1 anthonykim1 merged commit a2b007c into microsoft:main Nov 15, 2024
46 checks passed
@Tyriar
Copy link
Member

Tyriar commented Nov 15, 2024

@anthonykim1 I suspect this is related to the version of conpty being used. You should try see if the problem exists when terminal.integrated.experimental.windowsUseConptyDll is set to true.

@anthonykim1
Copy link
Author

anthonykim1 commented Nov 15, 2024

good point @Tyriar I think the hope is we would eventually enable shell integration on Windows and WSL too if the new conpty provide us more stability with command decorations prompt location(remember decorations kept on jumping around even after adding Python's prompt regex >>>), etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl area-terminal bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly differentiate Windows, Linux, and WSL in pythonrc.py script
3 participants