-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add news for LS fixes #2372
Add news for LS fixes #2372
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2372 +/- ##
========================================
- Coverage 76% 75.6% -0.4%
========================================
Files 309 309
Lines 14331 14331
Branches 2537 2537
========================================
- Hits 10892 10835 -57
- Misses 3429 3486 +57
Partials 10 10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but do we want to set up a setting that the user can manipulate the new asyncStartup: true
parameter?
@@ -262,7 +262,8 @@ export class LanguageServerExtensionActivator implements IExtensionActivator { | |||
excludeFiles: this.excludedFiles, | |||
testEnvironment: isTestExecution(), | |||
analysisUpdates: true, | |||
traceLogging | |||
traceLogging, | |||
asyncStartup: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this hard-coded in this way? Should there be a user setting in VScode for this?
Should this also mention #2017? |
@patrys - thanks, added. |
Add flag for upcoming LS startup time improvement.
"1.2.3"
, not"^1.2.3"
)