Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add news for LS fixes #2372

Merged
merged 45 commits into from
Aug 10, 2018
Merged

Add news for LS fixes #2372

merged 45 commits into from
Aug 10, 2018

Conversation

MikhailArkhipov
Copy link

Add flag for upcoming LS startup time improvement.

  • Title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Unit tests & code coverage are not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)
  • Dependencies are pinned (e.g. "1.2.3", not "^1.2.3")

@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #2372 into master will decrease coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2372     +/-   ##
========================================
- Coverage      76%   75.6%   -0.4%     
========================================
  Files         309     309             
  Lines       14331   14331             
  Branches     2537    2537             
========================================
- Hits        10892   10835     -57     
- Misses       3429    3486     +57     
  Partials       10      10
Flag Coverage Δ
#MacOS ?
#Windows ?
Impacted Files Coverage Δ
src/client/activation/languageServer.ts 26.08% <ø> (ø) ⬆️
src/client/common/platform/registry.ts 40.42% <0%> (-51.07%) ⬇️
src/client/common/platform/pathUtils.ts 66.66% <0%> (-33.34%) ⬇️
src/client/common/utils.ts 57.89% <0%> (-18.43%) ⬇️
src/client/common/platform/serviceRegistry.ts 88.88% <0%> (-11.12%) ⬇️
src/client/common/platform/platformService.ts 84.21% <0%> (-5.27%) ⬇️
src/client/common/process/pythonProcess.ts 88.63% <0%> (-4.55%) ⬇️
src/client/refactor/proxy.ts 81.05% <0%> (-3.16%) ⬇️
src/client/unittests/unittest/socketServer.ts 79.45% <0%> (-2.74%) ⬇️
...interpreter/locators/services/KnownPathsService.ts 92.68% <0%> (-2.44%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e277e...a399fc4. Read the comment docs.

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but do we want to set up a setting that the user can manipulate the new asyncStartup: true parameter?

@@ -262,7 +262,8 @@ export class LanguageServerExtensionActivator implements IExtensionActivator {
excludeFiles: this.excludedFiles,
testEnvironment: isTestExecution(),
analysisUpdates: true,
traceLogging
traceLogging,
asyncStartup: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this hard-coded in this way? Should there be a user setting in VScode for this?

@patrys
Copy link

patrys commented Aug 10, 2018

Should this also mention #2017?

@MikhailArkhipov
Copy link
Author

@patrys - thanks, added.

@MikhailArkhipov MikhailArkhipov merged commit b2230f0 into microsoft:master Aug 10, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants