Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix banner text #2254

Merged
merged 2 commits into from
Jul 26, 2018
Merged

Fix banner text #2254

merged 2 commits into from
Jul 26, 2018

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented Jul 25, 2018

Fix for issue #2253

  • Title summarizes what is changing

@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #2254 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
- Coverage   79.82%   79.81%   -0.01%     
==========================================
  Files         310      310              
  Lines       14367    14367              
  Branches     2549     2549              
==========================================
- Hits        11468    11467       -1     
- Misses       2887     2888       +1     
  Partials       12       12
Flag Coverage Δ
#MacOS 73.96% <100%> (-0.04%) ⬇️
#Windows 74.12% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...ent/languageServices/languageServerSurveyBanner.ts 51.28% <100%> (ø) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 68.42% <0%> (-0.33%) ⬇️
src/client/debugger/Main.ts 66.91% <0%> (-0.25%) ⬇️
src/client/linters/lintingEngine.ts 92.03% <0%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81dea5...a4ce32f. Read the comment docs.

@d3r3kk d3r3kk merged commit b39a6c1 into microsoft:master Jul 26, 2018
@d3r3kk d3r3kk deleted the LSbannertext branch July 26, 2018 18:26
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants