Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature branch testing overflow bug fix #21812

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Feature branch testing overflow bug fix #21812

merged 4 commits into from
Aug 15, 2023

Commits on Aug 14, 2023

  1. undo reverts to feature branch (#21780)

    @eleanorjboyd
    eleanorjboyd committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    d1fcaa8 View commit details
    Browse the repository at this point in the history

  2. Consistent disposal of receivers across adapters (#21759) 

    Few items:
- every adapter has a disposeDataReceiver function
- all disposeDataReceiver functions handle uuid deleting creating a
single point of uuid deletion per adapter
- always end with the disposal of the receiver to ensure no repeat
receivers on retries
- cancelation and the end of a subprocess both result in the same
function call to cleanup
    @eleanorjboyd
    eleanorjboyd committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    de1a2db View commit details
    Browse the repository at this point in the history

  3. add std out to subprocess to stop overflow (#21758) 

    Displays output to the user and ensures the subprocess doesn't run into
buffer overflow. Bug was introduced with the switch to the
execObservable in #21667.
Only occurs for large repos where output from pytest was large enough to
reach buffer overflow.
    @eleanorjboyd
    eleanorjboyd committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    84df45c View commit details
    Browse the repository at this point in the history

  4. Add functional tests for test adapter (#21803) 

    closes #21767
    @eleanorjboyd
    eleanorjboyd authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    64478bf View commit details
    Browse the repository at this point in the history