Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax validation of environment path variable #2172

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

DonJayamanne
Copy link

Fixes #2076

  • Title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Unit tests & code coverage are not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)
  • [N/A] Dependencies are pinned (e.g. "1.2.3", not "^1.2.3")
  • [N/A] package-lock.json has been regenerated if dependencies have changed

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #2172 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2172      +/-   ##
==========================================
- Coverage    79.9%   79.88%   -0.03%     
==========================================
  Files         308      308              
  Lines       14167    14167              
  Branches     2519     2518       -1     
==========================================
- Hits        11320    11317       -3     
- Misses       2835     2838       +3     
  Partials       12       12
Flag Coverage Δ
#MacOS 73.96% <100%> (+0.04%) ⬆️
#Windows 74.07% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
.../application/diagnostics/checks/envPathVariable.ts 97.72% <100%> (ø) ⬆️
src/client/linters/baseLinter.ts 89.47% <0%> (-1.06%) ⬇️
src/client/debugger/Main.ts 66.91% <0%> (-0.25%) ⬇️
src/client/providers/jediProxy.ts 79.77% <0%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c4da0...6ca3119. Read the comment docs.

@brettcannon brettcannon merged commit 176c975 into microsoft:master Jul 17, 2018
bschley pushed a commit to bschley/vscode-python that referenced this pull request Aug 2, 2018
@DonJayamanne DonJayamanne deleted the issue2076 branch October 2, 2018 22:47
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weaken path separator check on Windows
3 participants