Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore languageServer files from vsix #2152

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

DonJayamanne
Copy link

Fixes #2150

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Jul 13, 2018

Codecov Report

Merging #2152 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2152      +/-   ##
==========================================
+ Coverage   79.86%   79.88%   +0.02%     
==========================================
  Files         308      308              
  Lines       14176    14176              
  Branches     2520     2520              
==========================================
+ Hits        11321    11324       +3     
+ Misses       2843     2840       -3     
  Partials       12       12
Flag Coverage Δ
#MacOS 73.92% <ø> (ø) ⬆️
#Windows 74.06% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...rc/client/debugger/PythonProcessCallbackHandler.ts 68.42% <0%> (-0.33%) ⬇️
src/client/providers/jediProxy.ts 80% <0%> (+0.22%) ⬆️
src/client/debugger/Main.ts 67.16% <0%> (+0.24%) ⬆️
src/client/debugger/PythonProcess.ts 59.16% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07c5fb...79c2842. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 9dc3209 into microsoft:master Jul 13, 2018
@DonJayamanne DonJayamanne deleted the issue2150 branch October 2, 2018 22:47
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'analysis' folder to .gitignore and .vscodeignore
2 participants