Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always display dunder variables when using new language server #2033

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

DonJayamanne
Copy link

Fixes #2013

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)

@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #2033 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2033      +/-   ##
==========================================
- Coverage   75.02%   75.02%   -0.01%     
==========================================
  Files         307      307              
  Lines       14060    14060              
  Branches     2493     2493              
==========================================
- Hits        10549    10548       -1     
- Misses       3374     3375       +1     
  Partials      137      137
Impacted Files Coverage Δ
src/client/linters/lintingEngine.ts 90.26% <0%> (-0.89%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c066c32...accf826. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 7334be7 into microsoft:master Jun 21, 2018
@DonJayamanne DonJayamanne deleted the issue2013SetDefaults branch October 2, 2018 22:49
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dunder variables not listed with new language server
3 participants