Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rename refactor unit tests #1955

Merged
merged 4 commits into from
Jun 14, 2018

Conversation

DonJayamanne
Copy link

Fixes #1953

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@@ -47,7 +47,7 @@ suite('Refactor Rename', () => {

test('Rename function in source without a trailing empty line', async () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails in Windows tests, perhaps because EOLUsedByRope in Windows is the dreaded \r\n?

After that is fixed I say good!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just rope using different separators. Looks like its inconsistent. I assumed it was using \n throughout, guess I was wrong.

@codecov
Copy link

codecov bot commented Jun 13, 2018

Codecov Report

Merging #1955 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1955      +/-   ##
==========================================
+ Coverage   74.48%   74.56%   +0.08%     
==========================================
  Files         285      285              
  Lines       13359    13359              
  Branches     2390     2390              
==========================================
+ Hits         9950     9961      +11     
+ Misses       3271     3260      -11     
  Partials      138      138
Impacted Files Coverage Δ
src/client/debugger/PythonProcess.ts 47.91% <0%> (+2.08%) ⬆️
src/client/debugger/mainV2.ts 81.12% <0%> (+2.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a520ca...09c701d. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 3c882b5 into microsoft:master Jun 14, 2018
@DonJayamanne DonJayamanne deleted the issue1953RefactorBugs branch June 20, 2018 03:13
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI errors for Code refactoring
2 participants