Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled rejected promises and fix tests #1921

Merged

Conversation

DonJayamanne
Copy link

Fixes #1918
Fixes #1919

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Jun 9, 2018

Codecov Report

Merging #1921 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1921      +/-   ##
==========================================
+ Coverage   74.36%   74.44%   +0.07%     
==========================================
  Files         282      282              
  Lines       13279    13279              
  Branches     2387     2387              
==========================================
+ Hits         9875     9885      +10     
+ Misses       3270     3261       -9     
+ Partials      134      133       -1
Impacted Files Coverage Δ
src/client/debugger/mainV2.ts 80.32% <0%> (+0.4%) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 54.27% <0%> (+0.65%) ⬆️
src/client/debugger/PythonProcess.ts 51.25% <0%> (+1.66%) ⬆️
src/client/common/installer/channelManager.ts 96.36% <0%> (+5.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e73764...ddcb505. Read the comment docs.

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine!

@DonJayamanne DonJayamanne merged commit 10f460e into microsoft:master Jun 11, 2018
@DonJayamanne DonJayamanne deleted the issue1918LogRejectedPromises branch June 20, 2018 03:13
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unhandled promise rejections Log unhandled promise rejections while running Unit Tests
2 participants