Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Typscript to v2.8.3 #1686

Merged
merged 2 commits into from
May 15, 2018
Merged

Upgrade Typscript to v2.8.3 #1686

merged 2 commits into from
May 15, 2018

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented May 14, 2018

Fixes #1604

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #1686 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1686      +/-   ##
==========================================
+ Coverage   71.38%   71.51%   +0.13%     
==========================================
  Files         277      277              
  Lines       13014    13014              
  Branches     2344     2344              
==========================================
+ Hits         9290     9307      +17     
+ Misses       3583     3570      -13     
+ Partials      141      137       -4
Impacted Files Coverage Δ
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (-1.32%) ⬇️
src/client/linters/lintingEngine.ts 91.22% <0%> (+0.87%) ⬆️
src/client/debugger/mainV2.ts 77.82% <0%> (+2.82%) ⬆️
src/client/debugger/PythonProcess.ts 51.25% <0%> (+5.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe442f9...81f9273. Read the comment docs.

@d3r3kk d3r3kk merged commit e26da1a into microsoft:master May 15, 2018
@d3r3kk d3r3kk deleted the typscript-2.8.3 branch May 15, 2018 14:35
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to TypeScript 2.8.3
2 participants