Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster node unit tests #12027

Merged
merged 3 commits into from
May 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion build/ci/templates/test_phases.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ steps:
compile: 'false'
sqlite: $(NeedsIPythonReqs)

# When running unit tests, we need to just compile extension code (not webviews & the like).
- task: Gulp@0
displayName: 'gulp compile'
inputs:
targets: 'compile'
condition: and(succeeded(), contains(variables['TestsToRun'], 'testUnitTests'))

# Run the `prePublishNonBundle` gulp task to build the binaries we will be testing.
# This produces the .js files required into the out/ folder.
# Example command line (windows pwsh):
Expand All @@ -42,7 +49,7 @@ steps:
displayName: 'gulp prePublishNonBundle'
inputs:
targets: 'prePublishNonBundle'
condition: and(succeeded(), not(contains(variables['TestsToRun'], 'testSmoke')))
condition: and(succeeded(), not(contains(variables['TestsToRun'], 'testSmoke')), not(contains(variables['TestsToRun'], 'testUnitTests')))

# Run the typescript unit tests.
#
Expand Down
1 change: 1 addition & 0 deletions news/3 Code Health/12027.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Faster node unit tests on Azure pipeline.
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,13 @@ suite('DataScience - ipywidget - CDN', () => {
let fileSystem: IFileSystem;
let webviewUriConverter: ILocalResourceUriConverter;
let tempFileCount = 0;
setup(function () {
suiteSetup(function () {
// Nock seems to fail randomly on CI builds. See bug
// https://github.com/microsoft/vscode-python/issues/11442
// tslint:disable-next-line: no-invalid-this
this.skip();
return this.skip();
});
setup(() => {
notebook = mock(JupyterNotebookBase);
configService = mock(ConfigurationService);
httpClient = mock(HttpClient);
Expand Down