Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for django and flask template debugging in experimental debugger #1200

Merged
merged 3 commits into from
Mar 26, 2018

Conversation

DonJayamanne
Copy link

Fixes #1189
Fixes #1190
Fixes #1198

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #1200 into master will increase coverage by 0.01%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
+ Coverage   71.94%   71.95%   +0.01%     
==========================================
  Files         260      260              
  Lines       11930    11936       +6     
  Branches     2118     2121       +3     
==========================================
+ Hits         8583     8589       +6     
  Misses       3219     3219              
  Partials      128      128
Impacted Files Coverage Δ
src/client/debugger/Main.ts 50.61% <0%> (ø) ⬆️
...lient/debugger/configProviders/pythonV2Provider.ts 100% <100%> (ø) ⬆️
src/client/debugger/Common/Contracts.ts 100% <100%> (ø) ⬆️
...c/client/debugger/DebugClients/LocalDebugClient.ts 51.96% <50%> (-0.46%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3626de2...ba8cec5. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 4ffb5be into microsoft:master Mar 26, 2018
@DonJayamanne DonJayamanne deleted the issue1189DjangoFlask branch June 20, 2018 03:19
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants