Add ability to disable the check on memory usage of language server (Jedi) process #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -158,7 +161,9 @@ export class JediProxy implements vscode.Disposable { | |||
| // Check memory footprint periodically. Do not check on every request due to | |||
| // the performance impact. See https://github.com/soyuka/pidusage - on Windows | |||
| // it is using wmic which means spawning cmd.exe process on every request. | |||
| setInterval(() => this.checkJediMemoryFootprint(), 2000); | |||
| if (this.shouldCheckJediMemoryFootprint()) { | |||
| setInterval(() => this.checkJediMemoryFootprint(), 2000); | |||
There was a problem hiding this comment.
Changing setting will require reload I think
There was a problem hiding this comment.
Yes. I think thats ok, rather than running some code every 2 seconds that does nothing.
I'm assuming only a handful of people would disable this.
MikhailArkhipov
approved these changes
Mar 22, 2018
Codecov Report
@@ Coverage Diff @@
## master #1156 +/- ##
==========================================
- Coverage 72.13% 71.94% -0.19%
==========================================
Files 260 260
Lines 11898 11925 +27
Branches 2112 2116 +4
==========================================
- Hits 8583 8580 -3
- Misses 3192 3221 +29
- Partials 123 124 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1036
@brettcannon @MikhailArkhipov
Added the word Jedi in release notes to be specific (I don't want anyone looking back at these old change log entries to link this
language serverto our newanalysis engine).Minor change: Moved
StopWatchfile intocommon.This pull request: