Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using pipenv, install packages (such as linters, test frameworks) in dev-packages #1134

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

DonJayamanne
Copy link

Fixes #1110

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Mar 21, 2018

Codecov Report

Merging #1134 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1134     +/-   ##
=========================================
- Coverage   71.81%   71.72%   -0.1%     
=========================================
  Files         260      260             
  Lines       11898    11898             
  Branches     2112     2112             
=========================================
- Hits         8545     8534     -11     
- Misses       3226     3232      +6     
- Partials      127      132      +5
Impacted Files Coverage Δ
src/client/common/installer/pipEnvInstaller.ts 72.22% <100%> (ø) ⬆️
src/client/debugger/PythonProcess.ts 43.33% <0%> (-2.09%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 51.64% <0%> (-1.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287fd8b...4a0f8f3. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 7c3ff8a into microsoft:master Mar 21, 2018
@DonJayamanne DonJayamanne deleted the issue1110 branch June 20, 2018 03:19
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pipenv install --dev for formatters, linters, etc...
2 participants