Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose currently selected interpreter path using API #11295

Merged
merged 6 commits into from
Apr 22, 2020

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Apr 21, 2020

For #11294

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@karrtikr karrtikr requested review from kimadeline and int19h April 21, 2020 14:43
src/client/api.ts Outdated Show resolved Hide resolved
@karrtikr karrtikr marked this pull request as draft April 21, 2020 18:09
@karrtikr
Copy link
Author

Blocked on the email thread where we're finalizing the design.

@karrtikr
Copy link
Author

Please re-review @int19h @kimadeline

@karrtikr karrtikr requested a review from int19h April 22, 2020 18:36
@karrtikr karrtikr marked this pull request as ready for review April 22, 2020 18:38
@karrtikr karrtikr requested a review from karthiknadig April 22, 2020 18:56
@karrtikr karrtikr removed the request for review from karthiknadig April 22, 2020 19:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #11295 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11295      +/-   ##
==========================================
- Coverage   61.12%   61.03%   -0.09%     
==========================================
  Files         602      604       +2     
  Lines       33147    33421     +274     
  Branches     4685     4732      +47     
==========================================
+ Hits        20260    20400     +140     
- Misses      11866    11995     +129     
- Partials     1021     1026       +5     
Impacted Files Coverage Δ
src/client/common/configSettings.ts 70.39% <ø> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...lient/datascience/jupyter/jupyterSessionManager.ts 7.07% <0.00%> (-1.11%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
...ascience/jupyter/liveshare/guestJupyterNotebook.ts 9.62% <0.00%> (-0.67%) ⬇️
...pplication/diagnostics/checks/pythonInterpreter.ts 91.07% <0.00%> (-0.60%) ⬇️
src/client/common/types.ts 100.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1a7e8c...b8046bd. Read the comment docs.

@karrtikr karrtikr merged commit 02533df into microsoft:master Apr 22, 2020
@karrtikr karrtikr deleted the settingsAPI branch April 22, 2020 20:10
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants