Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiments should not block on telemetry. #10940

Merged
merged 3 commits into from
Apr 3, 2020

Conversation

karthiknadig
Copy link
Member

For #10008

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).

@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #10940 into master will decrease coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10940      +/-   ##
==========================================
- Coverage   60.64%   60.62%   -0.03%     
==========================================
  Files         580      580              
  Lines       31560    31561       +1     
  Branches     4490     4490              
==========================================
- Hits        19141    19134       -7     
- Misses      11444    11449       +5     
- Partials      975      978       +3     
Impacted Files Coverage Δ
src/client/common/experiments.ts 96.35% <80.00%> (-1.45%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa23403...d8db2db. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@karthiknadig karthiknadig marked this pull request as ready for review April 3, 2020 01:56
@karthiknadig karthiknadig merged commit dfbfed3 into microsoft:master Apr 3, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
@karthiknadig karthiknadig deleted the issue10008 branch April 28, 2020 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants