Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update min version of reflect-metadata in package.json to latest build #594

Closed
DonJayamanne opened this issue Jan 17, 2018 · 3 comments · Fixed by #604
Closed

Update min version of reflect-metadata in package.json to latest build #594

DonJayamanne opened this issue Jan 17, 2018 · 3 comments · Fixed by #604
Assignees
@brettcannon @DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Milestone
January 2018

Comments

@DonJayamanne
Copy link

The latest version of reflect-metadata (npm package) has the fixe related to #432
We need to ensure the extension depends on this new version.
@DonJayamanne DonJayamanne added this to the January 2018 milestone Jan 17, 2018
@DonJayamanne DonJayamanne added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Jan 17, 2018
@brettcannon
Copy link
Member

So this will solve the inversify problem?

@DonJayamanne
Copy link
Author

So this will solve the inversify problem?

Yes

@brettcannon
Copy link
Member

I assume this is 0.1.12? (I've told CELA that's the version we are moving to.)

@DonJayamanne DonJayamanne mentioned this issue Jan 19, 2018
Merged
DonJayamanne added a commit that referenced this issue Jan 19, 2018
@DonJayamanne
update reflect metadata dependency (#604)
ba069d2 
Fixes #594
@brettcannon brettcannon mentioned this issue Jan 29, 2018
Closed
38 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brettcannon brettcannon

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Projects
None yet
Milestone
January 2018
Development

Successfully merging a pull request may close this issue.

update reflect metadata dependency DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne