Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of automatic environment detection #372

Closed
DonJayamanne opened this issue Dec 7, 2017 · 2 comments · Fixed by #380 or #405
Closed

Improve performance of automatic environment detection #372

DonJayamanne opened this issue Dec 7, 2017 · 2 comments · Fixed by #380 or #405
Assignees
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone

Comments

@DonJayamanne
Copy link

When extension loads, it attempts to automatically set the workspace interpreter.
However this slows down the load times of the extension.
Optimizations: manually construct VirtualEnvService passing in the current workspace.

@DonJayamanne DonJayamanne added feature-extension debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Dec 7, 2017
@Yensan
Copy link

Yensan commented Dec 8, 2017

Hi, @DonJayamanne , I don't think detect python env is a good decision. As an user I always set the env by myself. Maybe there are so many python: (2.x OR 3.x) * (32bit OR 64bit) * (install OR virture env)
But performance and intelisense is not very well in vscode-python:

  • it will cause break or zoombie to vscode and windows
  • intelisense for import expression such as import sys. , and if a package is import, the class/func/var can intellisense in that file.

@DonJayamanne
Copy link
Author

DonJayamanne commented Dec 8, 2017

Please create a separate issue for performance issues faced in intellisense. If you are experiencing performance issues with auto detection of the interpreter, them please create an issue for that as well.
The decision has been made to improve the ux for the user by auto detection the virtual env, and we believe this ux can be improved further. Hence this issue.

But performance and intelisense is not very well in vscode-python:

So please create issues for this with some measurable data.

As you can see we are taking steps to improve the performance around intellisense with PRs such as the following: #368

@DonJayamanne DonJayamanne added this to the December 2017 milestone Dec 9, 2017
DonJayamanne added a commit that referenced this issue Dec 11, 2017
* Add support for pip and/or conda when installing modules
* Fix display versions for environments (fixes #378)
* Refactor installer to use the pip/conda module installer for installation of modules
* Performance improvement of detecting virtual env and setting it (fixes #372)
* Code refactor to ensure interpreter locators use the new DI framework
* Fixes #266
@DonJayamanne DonJayamanne reopened this Dec 12, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
3 participants