Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocompletion triggered inside strings and comments #34

Closed
ivan-baldin opened this issue Nov 10, 2017 · 1 comment · Fixed by #339
Closed

Autocompletion triggered inside strings and comments #34

ivan-baldin opened this issue Nov 10, 2017 · 1 comment · Fixed by #339
Assignees
@MikhailArkhipov
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality
Milestone
December 2017

Comments

@ivan-baldin
Copy link

ivan-baldin commented Nov 10, 2017 •
edited
Loading

Environment data

VS Code version: 1.18.0
Python Extension version:
Python Version: 0.8.0
OS and version: Ubuntu 16.04 based Linux and Windows 10

Actual behavior

vscode tries to provide auto complete suggestions inside python strings every time period is pressed. This doesn't happen in c/c++ files, don't know about other file types. Also comments doesn't seem to be affected.

Settings tweaks tested with no effect:

  • "editor.quickSuggestions": {"other": false, "comments": false, "strings": false}
  • "editor.wordBasedSuggestions": false

Period triggered suggestions are pretty messed up in general, e.g. typing 1. results in suggestion list and, if, in, is, not, or. Very useful.

Expected behavior

Strings shouldn't be treated as code in general. Let me write docstrings in peace.

Steps to reproduce:

  1. Create new file
  2. Select language mode: Python
  3. Type ".

Logs

Nothing related.
@DonJayamanne DonJayamanne added the feature-request Request for new features or functionality label Nov 14, 2017
@brettcannon brettcannon added awaiting 1-decision area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. labels Nov 14, 2017
@MikhailArkhipov MikhailArkhipov self-assigned this Dec 1, 2017
@MikhailArkhipov MikhailArkhipov mentioned this issue Dec 5, 2017
Merged
@brettcannon brettcannon added this to the December 2017 milestone Dec 5, 2017
MikhailArkhipov pushed a commit that referenced this issue Dec 5, 2017
#34, #110 - suppress Intellisense in strings and comments (#339)
1150480 
* Basic tokenizer

* Fixed property names

* Tests, round I

* Tests, round II

* tokenizer test

* Remove temorary change

* Fix merge issue

* Merge conflict

* Merge conflict

* Completion test

* Fix last line

* Fix javascript math

* Make test await for results

* Add license headers

* Rename definitions to types

* License headers
@MikhailArkhipov
Copy link

1150480

@brettcannon brettcannon changed the title Autocompletion triggered inside strings Autocompletion triggered inside strings and comments Dec 5, 2017
DonJayamanne added a commit that referenced this issue Dec 14, 2017
@DonJayamanne
Merge remote-tracking branch 'upstream/master'
b16d2f9 
* upstream/master:
  #34, #110 - suppress Intellisense in strings and comments (#339)
  Re-factor code python execution framework  (#345)
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikhailArkhipov MikhailArkhipov

Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality
Projects
None yet
Milestone
December 2017
Development

Successfully merging a pull request may close this issue.

#34, #110 - suppress Intellisense in strings and comments
4 participants
@brettcannon @DonJayamanne @ivan-baldin @MikhailArkhipov