Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate pythonExecutionFactory and Select Interpreter #24190

Closed
anthonykim1 opened this issue Sep 25, 2024 · 2 comments
Closed

Investigate pythonExecutionFactory and Select Interpreter #24190

anthonykim1 opened this issue Sep 25, 2024 · 2 comments
Assignees
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team

Comments

@anthonykim1
Copy link

anthonykim1 commented Sep 25, 2024

Related: #24122

We may be selecting undesired conda environment in

const condaExecutionService = await this.createCondaExecutionService(pythonPath, processService);
if (condaExecutionService) {
return condaExecutionService;
}
const env = createPythonEnv(pythonPath, processService, this.fileSystem);
return createPythonService(processService, env);
which are used for getting Python executable for testing purposes, etc.

TODO:

  1. Investigate how pythonexecutionFactory is related to Select interpreter dropdown we have. => These two are separate things.
  2. Ensure these two Python environment/executables are aligned.
  3. Potentially look into some environment service where we can store the state of currently selected environment.

/cc @eleanorjboyd

@anthonykim1 anthonykim1 added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-environments Features relating to handling interpreter environments labels Sep 25, 2024
@anthonykim1 anthonykim1 self-assigned this Sep 25, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 25, 2024
@anthonykim1 anthonykim1 added this to the October 2024 milestone Sep 25, 2024
@anthonykim1
Copy link
Author

#24198 Should help abit?? I'm not too confident this resolved the problem.

anthonykim1 added a commit that referenced this issue Oct 4, 2024
…4250)

Resolves: #24122
Related: #24190,
#24127

I think the culprit was we were not passing in interpreter when we call
createActivatedEnvironment.
karthiknadig pushed a commit that referenced this issue Oct 7, 2024
…4250)

Resolves: #24122
Related: #24190,
#24127

I think the culprit was we were not passing in interpreter when we call
createActivatedEnvironment.
karthiknadig pushed a commit that referenced this issue Oct 7, 2024
…4250)

Resolves: #24122
Related: #24190,
#24127

I think the culprit was we were not passing in interpreter when we call
createActivatedEnvironment.
@anthonykim1
Copy link
Author

Seems resolved from #24122 on v2024.17.2024101501 or higher.

@anthonykim1 anthonykim1 removed this from the October 2024 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

No branches or pull requests

1 participant