Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically activate terminals created by the user when not using the Python command #1387

Closed
DonJayamanne opened this issue Apr 13, 2018 · 11 comments · Fixed by #2277
Closed
Assignees
Labels
area-terminal feature-request Request for new features or functionality

Comments

@DonJayamanne
Copy link

DonJayamanne commented Apr 13, 2018

microsoft/vscode#46192

This world allow us to automatically activate environments.

Use the following event:

const myTerm = createTerminal();
window.onDidOpenTerminal(t => {
  if (t !== myTerm) {
    // do stuff here
  }
});
@DonJayamanne DonJayamanne changed the title Automatically activation terminals created by the user Automatically activate terminals created by the user when not using the Python command Apr 13, 2018
@DonJayamanne DonJayamanne added feature-request Request for new features or functionality needs PR labels Apr 14, 2018
@DonJayamanne DonJayamanne self-assigned this Apr 27, 2018
@brettcannon
Copy link
Member

Without VS Code providing a UI for controlling the "type" of terminal the user wants, having this be opt-out is probably too much when we have a command as-is. If VS Code did add the appropriate UI, though, this would be good.

@DonJayamanne
Copy link
Author

Without VS Code providing a UI for controlling the "type" of terminal the user wants

Why do we need this type. Why not just activate it regardless.

@brettcannon
Copy link
Member

Because @qubitron doesn't like the idea since he uses both Node and Python in the same project 😁

@qubitron
Copy link

I was extrapolating from my own experience that a polyglot developer that only uses Python for a part of their app would be annoyed that we always activate Python in the terminal and we don't have an easy way to say "create me a terminal without python". At the same time, many people have asked to automatically activate Python in the terminal (or are confused when it doesn't happen).

Thinking more about it... more would probably benefit from a default activated terminal than would be annoyed, so it's probably better tradeoff to type "deactivate" when you don't want the activated python terminal. In case it really disrupts people's workflows or causes issues, we can add an option to disable the feature and they can fall back to using the "Python: Create Terminal" command.

@brettcannon
Copy link
Member

Labels changed to reflect the new thinking.

@tiarno
Copy link

tiarno commented Jun 7, 2018

I was looking for a way to open two Python terminals side by side. I think the default activated terminal would work for that, so +1.

@DonJayamanne
Copy link
Author

@tiarno, I've tried that myself, and have resorted to manually activating the terminal in the side.

@alexwhittemore

This comment has been minimized.

@DonJayamanne

This comment has been minimized.

@alexwhittemore

This comment has been minimized.

@DonJayamanne

This comment has been minimized.

@brettcannon brettcannon added this to the Sep 2018 milestone Aug 15, 2018
@brettcannon brettcannon modified the milestones: Sep 2018, September 2018 Sprint 1 Sep 6, 2018
@brettcannon brettcannon reopened this Sep 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants