Use vanillajs instead of ts for build scripts (#9366)

* Remove ts code from build scripts
* News entry
* Verify format of js code

build/ci/postInstall.js

@@ -1,11 +1,11 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 'use strict';
-exports.__esModule = true;
-var colors = require("colors/safe");
-var fs = require("fs");
-var path = require("path");
-var constants_1 = require("../constants");
+
+var colors = require('colors/safe');
+var fs = require('fs');
+var path = require('path');
+var constants_1 = require('../constants');
 /**
  * In order to compile the extension in strict mode, one of the dependencies (@jupyterlab) has some files that
  * just won't compile in strict mode.
@@ -22,21 +22,20 @@ function fixJupyterLabDTSFiles() {
     var fileContents = fs.readFileSync(filePath, { encoding: 'utf8' });
     if (fileContents.indexOf('[key: string]: ISchema | undefined;') > 0) {
         // tslint:disable-next-line:no-console
-        console.log(colors.blue(relativePath + " file already updated (by Python VSC)"));
+        console.log(colors.blue(relativePath + ' file already updated (by Python VSC)'));
         return;
     }
     if (fileContents.indexOf('[key: string]: ISchema;') > 0) {
         var replacedText = fileContents.replace('[key: string]: ISchema;', '[key: string]: ISchema | undefined;');
         if (fileContents === replacedText) {
-            throw new Error('Fix for JupyterLabl file \'settingregistry.d.ts\' failed (pvsc post install script)');
+            throw new Error("Fix for JupyterLabl file 'settingregistry.d.ts' failed (pvsc post install script)");
         }
         fs.writeFileSync(filePath, replacedText);
         // tslint:disable-next-line:no-console
-        console.log(colors.green(relativePath + " file updated (by Python VSC)"));
-    }
-    else {
+        console.log(colors.green(relativePath + ' file updated (by Python VSC)'));
+    } else {
         // tslint:disable-next-line:no-console
-        console.log(colors.red(relativePath + " file does not need updating."));
+        console.log(colors.red(relativePath + ' file does not need updating.'));
     }
 }
 fixJupyterLabDTSFiles();

build/ci/templates/jobs/build_compile.yml

@@ -32,3 +32,7 @@ jobs:
     - bash: npx prettier "src/**/*.ts*" --check
       displayName: "Code Format"
       workingDirectory: $(Build.SourcesDirectory)
+
+    - bash: npx prettier "build/**/*.js" --check
+      displayName: "Code Format"
+      workingDirectory: $(Build.SourcesDirectory)

build/constants.js

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 'use strict';
-Object.defineProperty(exports, "__esModule", { value: true });
-const util = require("./util");
+
+const util = require('./util');
 exports.ExtensionRootDir = util.ExtensionRootDir;
 // This is a list of files that existed before MS got the extension.
 exports.existingFiles = util.getListOfFiles('existingFiles.json');

build/contributedFiles.json

@@ -1,2 +1 @@
-[
-]
+[]

build/tslint-rules/baseRuleWalker.js

@@ -1,10 +1,10 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 'use strict';
-Object.defineProperty(exports, "__esModule", { value: true });
-const path = require("path");
-const Lint = require("tslint");
-const util = require("../util");
+
+const path = require('path');
+const Lint = require('tslint');
+const util = require('../util');
 class BaseRuleWalker extends Lint.RuleWalker {
     shouldIgnoreCurrentFile(node, filesToIgnore) {
         const sourceFile = node.getSourceFile();

build/tslint-rules/messagesMustBeLocalizedRule.js

@@ -1,32 +1,35 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 'use strict';
-Object.defineProperty(exports, "__esModule", { value: true });
-const path = require("path");
-const Lint = require("tslint");
-const ts = require("typescript");
-const util = require("../util");
-const baseRuleWalker_1 = require("./baseRuleWalker");
+
+const path = require('path');
+const Lint = require('tslint');
+const ts = require('typescript');
+const util = require('../util');
+const baseRuleWalker = require('./baseRuleWalker');
 const methodNames = [
     // From IApplicationShell (vscode.window):
-    'showErrorMessage', 'showInformationMessage',
-    'showWarningMessage', 'setStatusBarMessage',
+    'showErrorMessage',
+    'showInformationMessage',
+    'showWarningMessage',
+    'setStatusBarMessage',
     // From IOutputChannel (vscode.OutputChannel):
-    'appendLine', 'appendLine'
+    'appendLine',
+    'appendLine'
 ];
 // tslint:ignore-next-line:no-suspicious-comments
 // TODO: Ideally we would not ignore any files.
 const ignoredFiles = util.getListOfFiles('unlocalizedFiles.json');
 const ignoredPrefix = path.normalize('src/test');
 const failureMessage = 'Messages must be localized in the Python Extension (use src/client/common/utils/localize.ts)';
-class NoStringLiteralsInMessages extends baseRuleWalker_1.BaseRuleWalker {
+class NoStringLiteralsInMessages extends baseRuleWalker.BaseRuleWalker {
     visitCallExpression(node) {
         if (!this.shouldIgnoreNode(node)) {
             node.arguments
                 .filter(arg => ts.isStringLiteral(arg) || ts.isTemplateLiteral(arg))
                 .forEach(arg => {
-                this.addFailureAtNode(arg, failureMessage);
-            });
+                    this.addFailureAtNode(arg, failureMessage);
+                });
         }
         super.visitCallExpression(node);
     }

build/util.js

@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 'use strict';
-Object.defineProperty(exports, "__esModule", { value: true });
-const fs = require("fs");
-const path = require("path");
+
+const fs = require('fs');
+const path = require('path');
 exports.ExtensionRootDir = path.dirname(__dirname);
 function getListOfFiles(filename) {
     filename = path.normalize(filename);
@@ -12,8 +12,7 @@ function getListOfFiles(filename) {
     }
     const data = fs.readFileSync(filename).toString();
     const files = JSON.parse(data);
-    return files
-        .map(file => {
+    return files.map(file => {
         return path.join(exports.ExtensionRootDir, file.replace(/\//g, path.sep));
     });
 }