Allow code like ABC123 for flake8 v3 plugin (#6925)

* change REGEX for flake8 v3 * create news file for fixing #4074
microsoft · Aug 23, 2019 · 7b4e7c0 · 7b4e7c0
1 parent a5d39a9
commit 7b4e7c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/news/2 Fixes/4074.md b/news/2 Fixes/4074.md
@@ -0,0 +1 @@
+Supports error codes like ABC123 as used in plugins.
diff --git a/src/client/linters/baseLinter.ts b/src/client/linters/baseLinter.ts
@@ -19,7 +19,8 @@ import {
 // tslint:disable-next-line:no-require-imports no-var-requires no-any
 const namedRegexp = require('named-js-regexp');
 // Allow negative column numbers (https://github.com/PyCQA/pylint/issues/1822)
-const REGEX = '(?<line>\\d+),(?<column>-?\\d+),(?<type>\\w+),(?<code>\\w\\d+):(?<message>.*)\\r?(\\n|$)';
+// Allow codes with more than one letter (i.e. ABC123)
+const REGEX = '(?<line>\\d+),(?<column>-?\\d+),(?<type>\\w+),(?<code>\\w+\\d+):(?<message>.*)\\r?(\\n|$)';
 
 export interface IRegexGroup {
     line: number;