-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Branch Creation UX and Refactor Issue Branch Management #6278
base: main
Are you sure you want to change the base?
Enhance Branch Creation UX and Refactor Issue Branch Management #6278
Conversation
- Implemented a `QuickPick` menu for smoother branch selection and creation process. - Highlighted suggested branch names with visual cues for better user experience. - Enhanced handling of remote branches, ensuring upstream is set automatically when needed. - Removed unnecessary methods (`offerNewBranch`, `getBranchTitle`) to simplify code and improve maintainability. - Improved branch name validation and error messages to provide more helpful feedback.
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cxc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ujghm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It looks like there are a lot of changes in here that aren't strictly related to the feature you're adding, which makes it slow to review. Could you please remove these changes? I've also left a few other comments.
- Refactored getBranchTitle() to correctly apply the ISSUE_BRANCH_TITLE setting by using variableSubstitution(). - Improved handling of the silent flag. - Cleaned up unrelated code changes.
@alexr00 Thanks for the feedback! I’ve addressed the specific comments and focused on ensuring the necessary changes related to the feature. |
This PR introduces significant improvements to the branch creation and management process, focusing on enhancing the user experience and refactoring the existing code for better maintainability and performance. Key changes include:
Branch Selection UI Overhaul:
Some Related Issues:
These issues are addressed by improving the branch selection experience, handling remote branches more seamlessly, and enhancing error feedback.
Testing and Verification:
Manual Testing: