Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt-in to always prompt for repo for issue creation and add comment to issue file specifying the repo #6115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mikeseese
Copy link

This PR adds a githubIssues.alwaysPromptForNewIssueRepo config variable that defaults to false. When set to true, if the user creates a new issue via the + button in the side panel, the extensions will always prompt the user for a repo to create the issue for instead of using the current open file. Behavior should not change for creating issues from selection/etc that are supposed to be directly contextual.

This PR also adds a comment in the NewIssue.md file telling the user which repo the issue will be created in if it's available:

image

This PR fixes #2099.

@mikeseese
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have some comments.

src/issues/issueFeatureRegistrar.ts Outdated Show resolved Hide resolved
src/issues/issueFeatureRegistrar.ts Outdated Show resolved Hide resolved
src/issues/issueFeatureRegistrar.ts Outdated Show resolved Hide resolved
src/issues/issueFile.ts Outdated Show resolved Hide resolved
@mikeseese mikeseese force-pushed the feat/multi-repo-issue-creation branch from c9c174f to 6f68dfc Compare July 29, 2024 19:27
@mikeseese mikeseese requested a review from alexr00 July 29, 2024 19:27
@mikeseese
Copy link
Author

mikeseese commented Jul 29, 2024

@alexr00 It got a little more complex, but now origin will contain information to reproduce the correct folder manager and remote by adding a new repo URI scheme.

@rzhao271
Copy link
Contributor

Merge conflict
Moving the milestone

@rzhao271 rzhao271 modified the milestones: October 2024, November 2024 Oct 25, 2024
@mikeseese
Copy link
Author

@rzhao271 @alexr00 Merge conflicts have been resolved. This PR is still waiting for a rereview. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hint which repo an issue will be opened in
4 participants