Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to move to file decorators for file with comments #161

Closed
kieferrm opened this issue Aug 10, 2018 · 3 comments
Closed

Need to move to file decorators for file with comments #161

kieferrm opened this issue Aug 10, 2018 · 3 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority upstream/vscode verified Verification succeeded
Milestone
August 2018

Comments

@kieferrm
Copy link
Member

Issue Type: Bug

We now have file decorators in the custom trees. We should move to use those.

Extension version: 0.0.9
VS Code version: Code - Insiders 1.27.0-insider (e3e972589db57a16da6426828706ced9c2d52848, 2018-08-09T23:55:15.226Z)
OS version: Windows_NT ia32 10.0.17134
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Aug 10, 2018
@rebornix
Copy link
Member

rebornix commented Aug 13, 2018 •
edited
Loading

Probably blocked by microsoft/vscode#54939 (comment)

update
As it's called file decorators, it makes sense that it only works for tree items with file scheme. We can still use file scheme for File Change Node resource uri.

@rebornix
Copy link
Member

As mentioned in microsoft/vscode#54939 (comment)
, decoration provider for all schemes will be implemented microsoft/vscode#54938

@rebornix rebornix added upstream/vscode important Issue identified as high-priority labels Aug 13, 2018
rebornix added a commit that referenced this issue Aug 20, 2018
@rebornix
Re #161. File decoration provider.
9d0f5e5
@rebornix rebornix added this to the August 2018 milestone Aug 23, 2018
@roblourens
Copy link
Member

I see a diamond shape on entries that have comments, I assume that's what this is about.

@roblourens roblourens added the verified Verification succeeded label Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority upstream/vscode verified Verification succeeded
Projects
None yet
Milestone
August 2018
Development

No branches or pull requests
4 participants
@roblourens @rebornix @RMacfarlane @kieferrm