Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip emoji from local header reference or provide an option to do that #171

Closed
unional opened this issue Mar 27, 2024 · 2 comments · Fixed by #175
Closed

Strip emoji from local header reference or provide an option to do that #171

unional opened this issue Mar 27, 2024 · 2 comments · Fixed by #175
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug markdown

Comments

@unional
Copy link

unional commented Mar 27, 2024

image

DavidAnson/markdownlint#1162 (comment)

GitHub representation which is described at the bottom of the documentation and does not include emoji: https://github.com/DavidAnson/markdownlint/blob/main/doc/md051.md
@unional
Copy link
Author

unional commented Mar 27, 2024

image
Also, when doing that, the reference is recognized (see the underscore), but navigation doesn't work.

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown labels Mar 27, 2024
@mjbvz mjbvz transferred this issue from microsoft/vscode Mar 28, 2024
@mjbvz
Copy link
Contributor

mjbvz commented Mar 28, 2024

Should likely just adopt https://github.com/Flet/github-slugger

mjbvz added a commit to mjbvz/vscode-markdown-languageservice that referenced this issue Apr 4, 2024
@mjbvz
Use github-slugify
4aeb052 
Fixes microsoft#171
@mjbvz mjbvz mentioned this issue Apr 4, 2024
Merged
@mjbvz mjbvz closed this as completed in #175 Apr 4, 2024
@unional unional mentioned this issue Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use github-slugify mjbvz/vscode-markdown-languageservice
2 participants
@unional @mjbvz